Messages in this thread | | | From | John Stultz <> | Date | Wed, 23 Nov 2022 10:54:27 -0800 | Subject | Re: [PATCH] time: copy tai value (International Atomic Time, in seconds) to output __user struct in get_old_timex32(). |
| |
On Sun, Nov 20, 2022 at 9:54 PM Jacob Macneal <jake.macneal@gmail.com> wrote: > > Previously, this value was not copied into the output struct. This is > despite all other fields of the corresponding __kernel_timex struct being > copied to the old_timex32 __user struct in this function. > > Additionally, the matching function put_old_timex32() expects a tai value > to be supplied, and copies it appropriately. It would appear to be a > mistake that this value was never copied over in get_old_timex32(). > > Signed-off-by: Jacob Macneal <jake.macneal@gmail.com> > --- > kernel/time/time.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/time/time.c b/kernel/time/time.c > index 526257b3727c..7da9951b033a 100644 > --- a/kernel/time/time.c > +++ b/kernel/time/time.c > @@ -311,6 +311,7 @@ int get_old_timex32(struct __kernel_timex *txc, const struct old_timex32 __user > txc->calcnt = tx32.calcnt; > txc->errcnt = tx32.errcnt; > txc->stbcnt = tx32.stbcnt; > + txc->tai = tx32.tai; >
This does seem like something that was overlooked.
Arnd: There isn't something more subtle I'm missing here, right?
Otherwise: Acked-by: John Stultz <jstultz@google.com>
thanks -john
| |