lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/11] blk-throttle: remove unnecessary check for validation of limit index
On Wed, Nov 23, 2022 at 02:03:59PM +0800, Kemeng Shi wrote:
> We always keep limit index valid as following:
> Max limit is always valid and low limit can only be invalidated in
> blk_throtl_update_limit_valid. Each time low limit may become invalid
> after blk_throtl_update_limit_valid is called, we will check and make
> sure current limit index is valid.
>
> It's reasonable to always keep limit index valid, so we can remove this
> check.

It's not obvious to me that it's correct and I'm not sure what we're gaining
by removing this while risking subtle breakages.

--
tejun

\
 
 \ /
  Last update: 2022-11-23 19:34    [W:0.158 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site