Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v4 1/2] fscache,cachefiles: add prepare_ondemand_read() callback | Date | Wed, 23 Nov 2022 16:44:43 +0000 |
| |
Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
> -/* > - * Prepare a read operation, shortening it to a cached/uncached > - * boundary as appropriate. > - */ > -static enum netfs_io_source cachefiles_prepare_read(struct netfs_io_subrequest *subreq, > - loff_t i_size) > +static inline enum netfs_io_source > +cachefiles_do_prepare_read(struct netfs_cache_resources *cres, > + loff_t start, size_t *_len, loff_t i_size, > + unsigned long *_flags)
That's not exactly what I meant, but I guess it would work as the compiler would probably inline it into both callers.
> - __entry->netfs_inode, __entry->cache_inode) > + __entry->cache_inode)
Can you not lose the netfs_inode number from the tracepoint, please? Feel free to display 0 there for your purposes.
David
| |