lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()
    Date
    If prestera_port_sfp_bind() fails, unregister_netdev() should be called
    in error handling path.

    Compile tested only.

    Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    ---
    drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
    index 24f9d60..47796e4 100644
    --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
    +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
    @@ -746,6 +746,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
    return 0;

    err_sfp_bind:
    + unregister_netdev(dev);
    err_register_netdev:
    prestera_port_list_del(port);
    err_port_init:
    --
    2.9.5
    \
     
     \ /
      Last update: 2022-11-22 11:52    [W:7.219 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site