lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188
From
On 22/11/2022 10:10, Elvis Wang (王军) wrote:
> On Mon, 2022-11-07 at 12:18 +0100, Matthias Brugger wrote:
>>
>> On 06/11/2022 11:27, Krzysztof Kozlowski wrote:
>>> On 04/11/2022 08:44, Elvis.Wang wrote:
>>>> From: Elvis Wang <Elvis.Wang@mediatek.com>
>>>>
>>>> add gce header file to define the gce thread priority, gce subsys
>>>> id,
>>>> event and constant for mt8188.
>>>>
>>>> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
>>>> ---
>>>> Thanks for the reviews, I have removed the incorrect reviewed
>>>> message.
>>>> ---
>>>> include/dt-bindings/gce/mediatek,mt8188-gce.h | 966
>>>> ++++++++++++++++++
>>>> 1 file changed, 966 insertions(+)
>>>> create mode 100644 include/dt-bindings/gce/mediatek,mt8188-
>>>> gce.h
>>>>
>>>> diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h
>>>> b/include/dt-bindings/gce/mediatek,mt8188-gce.h
>>>> new file mode 100644
>>>> index 000000000000..e2e2c56016a1
>>>> --- /dev/null
>>>> +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h
>>>
>>>
>>> What is a "gce" subsystem or type of hardware? Why do you put
>>> headers in
>>> "gce"?
>>>
>>
>> Yes, I think we should move all header files from the gce folder into
>> the
>> mailbox folder.
>>
>> Regards,
>> Matthias
>
> There are still a lot of header files undre gce. If all of them are
> moved, it will also involve the modification of yaml and corresponding
> project dts files, which requires more effort. Can we deal with the
> 8188 part first?

Sure, just put the new bindings in proper location (mailbox if this is a
Mailbox).

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-22 10:27    [W:0.043 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site