lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/30] selftests/rseq: Fix: Fail thread registration when CONFIG_RSEQ=n
    Date
    When linking the selftests against a libc which does not handle rseq
    registration (before 2.35), rseq thread registration silently succeed
    even with CONFIG_RSEQ=n because it erroneously thinks that libc is
    handling rseq registration.

    This is caused by setting the rseq ownership flag only after the
    rseq_available() check. It should rather be set before the
    rseq_available() check.

    Set the rseq_size to 0 (error value) immediately after the
    rseq_available() check fails rather than in the thread registration
    functions.

    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    ---
    tools/testing/selftests/rseq/rseq.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/tools/testing/selftests/rseq/rseq.c b/tools/testing/selftests/rseq/rseq.c
    index 4177f9507bbe..376a73f1ac41 100644
    --- a/tools/testing/selftests/rseq/rseq.c
    +++ b/tools/testing/selftests/rseq/rseq.c
    @@ -119,9 +119,11 @@ void rseq_init(void)
    rseq_flags = *libc_rseq_flags_p;
    return;
    }
    - if (!rseq_available())
    - return;
    rseq_ownership = 1;
    + if (!rseq_available()) {
    + rseq_size = 0;
    + return;
    + }
    rseq_offset = (void *)&__rseq_abi - rseq_thread_pointer();
    rseq_size = sizeof(struct rseq_abi);
    rseq_flags = 0;
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-11-22 21:41    [W:4.143 / U:0.736 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site