Messages in this thread | | | Date | Mon, 21 Nov 2022 12:53:22 +0200 | Subject | Re: [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * | From | Nikolay Aleksandrov <> |
| |
On 21/11/2022 11:46, Greg Kroah-Hartman wrote: > The call, kobject_get_ownership(), does not modify the kobject passed > into it, so make it const. This propagates down into the kobj_type > function callbacks so make the kobject passed into them also const, > ensuring that nothing in the kobject is being changed here. > > This helps make it more obvious what calls and callbacks do, and do not, > modify structures passed to them. > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Trond Myklebust <trond.myklebust@hammerspace.com> > Cc: Anna Schumaker <anna@kernel.org> > Cc: Roopa Prabhu <roopa@nvidia.com> > Cc: Nikolay Aleksandrov <razor@blackwall.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Chuck Lever <chuck.lever@oracle.com> > Cc: Jeff Layton <jlayton@kernel.org> > Cc: linux-nfs@vger.kernel.org > Cc: bridge@lists.linux-foundation.org > Cc: netdev@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/base/class.c | 2 +- > drivers/base/core.c | 8 ++++---- > fs/nfs/sysfs.c | 4 ++-- > include/linux/kobject.h | 8 ++++---- > lib/kobject.c | 4 ++-- > net/bridge/br_if.c | 2 +- > net/core/net-sysfs.c | 8 ++++---- > net/sunrpc/sysfs.c | 8 ++++---- > 8 files changed, 22 insertions(+), 22 deletions(-) >
For the bridge: Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
| |