Messages in this thread | | | Date | Mon, 21 Nov 2022 10:27:40 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] gpiolib: Unify access to the device properties |
| |
On Sun, Nov 20, 2022 at 08:16:22PM +0100, Marijn Suijten wrote: > On 2022-11-16 16:17:28, Andy Shevchenko wrote: > > Some of the functions are using struct fwnode_handle, some struct device > > pointer. In the GPIO library the firmware node of the GPIO device is the > > same as GPIO node of the GPIO chip. Due to this fact we may use former > > to access properties everywhere in the code. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > I presume this is a more complete version of [1], as this also happens > to address the crash on MSM [1], hence: > > Tested-by: Marijn Suijten <marijn.suijten@somainline.org>
Thank you!
> Just in case, this seems to depend on [3] or it fails to apply cleanly > because of the `const` change on `fwnode` (consider this irrelevant if > it has already been applied, I'm still on -next-20221115 for this > integration branch).
But initial issue was induced by (my) patch which is only in gpio/for-next. It's supposed to be only Linux Next issue.
> [1]: https://lore.kernel.org/all/Y3S62i7OzocP5QrT@orome/ > [2]: https://lore.kernel.org/linux-arm-msm/20221115110800.35gl3j43lmbxm3jb@SoMainline.org/ > [3]: https://lore.kernel.org/linux-gpio/20221031-gpiolib-swnode-v3-0-0282162b0fa4@gmail.com/
-- With Best Regards, Andy Shevchenko
| |