lkml.org 
[lkml]   [2022]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 01/20] x86/tdx: Define TDX supported page sizes as macros
From


On 11/21/22 1:15 AM, Huang, Kai wrote:
> On Sun, 2022-11-20 at 18:52 -0800, Sathyanarayanan Kuppuswamy wrote:
>>
>> On 11/20/22 4:26 PM, Kai Huang wrote:
>>> +/*
>>> + * TDX supported page sizes (4K/2M/1G).
>>> + *
>>> + * Those values are part of the TDX module ABI. Do not change them.
>>
>> It would be better if you include specification version and section
>> title.
>>
>
> Such as below?
>
> "Those values are part of the TDX module ABI (section "Physical Page Size", TDX
> module 1.0 spec). Do not change them."

Yes.

>
> Btw, Dave mentioned we should not put the "section numbers" to the comment:
>
> https://lore.kernel.org/lkml/2a1886e7-fa5d-99e2-b1da-55ed7c0d024b@intel.com/
>
> I was trying to follow.

Yes. That's why suggested to put section title.

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

\
 
 \ /
  Last update: 2022-11-21 18:24    [W:0.261 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site