lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 3/4] arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs
    From
    On 31/10/2022 19:25, Melody Olvera wrote:
    >
    >
    > On 10/31/2022 2:49 PM, Melody Olvera wrote:
    >>
    >> On 10/27/2022 8:21 AM, Krzysztof Kozlowski wrote:
    >>> On 26/10/2022 16:04, Melody Olvera wrote:
    >>>> Add the base DTSI files for QDU1000 and QRU1000 SoCs, including base
    >>>> descriptions of CPUs, GCC, RPMHCC, QUP, TLMM, and interrupt-controller
    >>>> to boot to shell with console on these SoCs.
    >>>>
    >>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
    >>>> ---
    >>>> arch/arm64/boot/dts/qcom/qdu1000.dtsi | 1406 +++++++++++++++++++++++++
    >>> Please use scripts/get_maintainers.pl to get a list of necessary people
    >>> and lists to CC. It might happen, that command when run on an older
    >>> kernel, gives you outdated entries. Therefore please be sure you base
    >>> your patches on recent Linux kernel.
    >> Sure thing; we talked about this on a different patch.
    >>>> arch/arm64/boot/dts/qcom/qru1000.dtsi | 27 +
    >>>> 2 files changed, 1433 insertions(+)
    >>>> create mode 100644 arch/arm64/boot/dts/qcom/qdu1000.dtsi
    >>>> create mode 100644 arch/arm64/boot/dts/qcom/qru1000.dtsi
    >>>>
    >>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
    >>>> new file mode 100644
    >>>> index 000000000000..76474106e931
    >>>> --- /dev/null
    >>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
    >>>> @@ -0,0 +1,1406 @@
    >>>> +// SPDX-License-Identifier: BSD-3-Clause
    >>>> +/*
    >>>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
    >>>> + */
    >>> (...)
    >>>
    >>>> +
    >>>> + soc: soc@0 {
    >>>> + #address-cells = <2>;
    >>>> + #size-cells = <2>;
    >>>> + ranges = <0 0 0 0 0x10 0>;
    >>>> + dma-ranges = <0 0 0 0 0x10 0>;
    >>>> + compatible = "simple-bus";
    >>>> +
    >>>> + gcc: clock-controller@80000 {
    >>>> + compatible = "qcom,gcc-qdu1000", "syscon";
    >>>> + reg = <0x0 0x80000 0x0 0x1f4200>;
    >>>> + #clock-cells = <1>;
    >>>> + #reset-cells = <1>;
    >>>> + #power-domain-cells = <1>;
    >>>> + clocks = <&rpmhcc RPMH_CXO_CLK>, <&sleep_clk>;
    >>>> + clock-names = "bi_tcxo", "sleep_clk";
    >>>> + };
    >>>> +
    >>>> + gpi_dma0: dma-controller@900000 {
    >>>> + compatible = "qcom,sm6350-gpi-dma";
    >>> You should add here a specific compatible as well. Same in other places.
    >>> All places. I had impression we talked about this few times, so I don't
    >>> know what is missing on your side.
    >>>
    >>> This must be:
    >>> "qcom,qdu1000-gpi-dma", "qcom,sm6350-gpi-dma"
    >> Got it. I talked to Stephan and he said either your suggestion or just using
    >> preexisting compatibles would be ok. I thought it might be cleaner to not
    >> have the qdu compats, but I'm fine either way.
    > Coming back to this, it looks like this will fail dtb_check since compatible field is too long.
    > Is there an adjustment to the binding which needs to be made here?

    Every compatible must be documented, so yes, bindings needs changes.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-11-02 17:30    [W:6.516 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site