lkml.org 
[lkml]   [2022]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 14/18] nvmem: core: provide own priv pointer in post process callback
    Date
    It doesn't make any more sense to have a opaque pointer set up by the
    nvmem device. Usually, the layout isn't associated with a particular
    nvmem device. Instead, let the caller who set the post process callback
    provide the priv pointer.

    Signed-off-by: Michael Walle <michael@walle.cc>
    ---
    changes since v2:
    - don't drop the pointer but let the user specify an opaque pointer

    changes since v1:
    - new patch

    drivers/nvmem/core.c | 4 +++-
    include/linux/nvmem-provider.h | 5 ++++-
    2 files changed, 7 insertions(+), 2 deletions(-)

    diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
    index 9234c7d87a69..e03976f6ad1c 100644
    --- a/drivers/nvmem/core.c
    +++ b/drivers/nvmem/core.c
    @@ -53,6 +53,7 @@ struct nvmem_cell_entry {
    int bit_offset;
    int nbits;
    nvmem_cell_post_process_t read_post_process;
    + void *priv;
    struct device_node *np;
    struct nvmem_device *nvmem;
    struct list_head node;
    @@ -470,6 +471,7 @@ static int nvmem_cell_info_to_nvmem_cell_entry_nodup(struct nvmem_device *nvmem,
    cell->bytes = info->bytes;
    cell->name = info->name;
    cell->read_post_process = info->read_post_process;
    + cell->priv = info->priv;

    cell->bit_offset = info->bit_offset;
    cell->nbits = info->nbits;
    @@ -1558,7 +1560,7 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem,
    nvmem_shift_read_buffer_in_place(cell, buf);

    if (cell->read_post_process) {
    - rc = cell->read_post_process(nvmem->priv, id, index,
    + rc = cell->read_post_process(cell->priv, id, index,
    cell->offset, buf, cell->bytes);
    if (rc)
    return rc;
    diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
    index 12833fe4eb4d..cb0814f2ddae 100644
    --- a/include/linux/nvmem-provider.h
    +++ b/include/linux/nvmem-provider.h
    @@ -20,7 +20,8 @@ typedef int (*nvmem_reg_write_t)(void *priv, unsigned int offset,
    void *val, size_t bytes);
    /* used for vendor specific post processing of cell data */
    typedef int (*nvmem_cell_post_process_t)(void *priv, const char *id, int index,
    - unsigned int offset, void *buf, size_t bytes);
    + unsigned int offset, void *buf,
    + size_t bytes);

    enum nvmem_type {
    NVMEM_TYPE_UNKNOWN = 0,
    @@ -56,6 +57,7 @@ struct nvmem_keepout {
    * @np: Optional device_node pointer.
    * @read_post_process: Callback for optional post processing of cell data
    * on reads.
    + * @priv: Opaque data passed to the read_post_process hook.
    */
    struct nvmem_cell_info {
    const char *name;
    @@ -65,6 +67,7 @@ struct nvmem_cell_info {
    unsigned int nbits;
    struct device_node *np;
    nvmem_cell_post_process_t read_post_process;
    + void *priv;
    };

    /**
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-11-18 19:55    [W:5.735 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site