lkml.org 
[lkml]   [2022]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/5] drm/panel-edp: Use ktime_get_boottime for delays
    Hi,

    On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport <ddavenport@chromium.org> wrote:
    >
    > ktime_get is based on CLOCK_MONOTONIC which stops on suspend. On
    > suspend, the time that the panel was powerd off is recorded with
    > ktime_get, and on resume this time is compared to the current ktime_get
    > time to determine if the driver should wait for the panel to power down
    > completely before re-enabling it.
    >
    > Because we're using ktime_get, this delay doesn't account for the time
    > that the device is suspended, during which the power down delay may have
    > already elapsed.
    >
    > Change to use ktime_get_boottime throughout, which uses CLOCK_BOOTTIME
    > which does not stop when suspended. This ensures that the resume path
    > will not be delayed if the power off delay has already been met while
    > the device is suspended.
    >
    > Signed-off-by: Drew Davenport <ddavenport@chromium.org>
    >
    > ---
    >
    > drivers/gpu/drm/panel/panel-edp.c | 8 ++++----
    > 1 file changed, 4 insertions(+), 4 deletions(-)

    Reviewed-by: Douglas Anderson <dianders@chromium.org>

    \
     
     \ /
      Last update: 2022-11-17 22:16    [W:3.450 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site