lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] dt-bindings: PCI: qcom: Add SM8550 to binding
    From
    On 16/11/2022 13:35, Abel Vesa wrote:
    > Add the SM8550 platform to the binding.

    Subject: Drop redundant, second "binding"

    >
    > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
    > ---
    > .../devicetree/bindings/pci/qcom,pcie.yaml | 96 +++++++++++++++++++
    > 1 file changed, 96 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
    > index 54f07852d279..efa01a8411c4 100644
    > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
    > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
    > @@ -34,6 +34,8 @@ properties:
    > - qcom,pcie-sm8250
    > - qcom,pcie-sm8450-pcie0
    > - qcom,pcie-sm8450-pcie1
    > + - qcom,pcie-sm8550-pcie0
    > + - qcom,pcie-sm8550-pcie1

    I am not sure what's the benefit of encoding arbitrary IDs to compatible
    just to differentiate by clocks. The devices are basically the same, so
    compatible should be the same.

    > - qcom,pcie-ipq6018
    >
    > reg:
    > @@ -92,6 +94,10 @@ properties:
    > power-domains:
    > maxItems: 1
    >
    > + enable-gpios:
    > + description: GPIO controlled connection to ENABLE# signal
    > + maxItems: 1

    Does not look like used property...

    > +
    > perst-gpios:
    > description: GPIO controlled connection to PERST# signal
    > maxItems: 1
    > @@ -187,6 +193,8 @@ allOf:
    > - qcom,pcie-sm8250
    > - qcom,pcie-sm8450-pcie0
    > - qcom,pcie-sm8450-pcie1
    > + - qcom,pcie-sm8550-pcie0
    > + - qcom,pcie-sm8550-pcie1
    > then:
    > properties:
    > reg:
    > @@ -601,6 +609,92 @@ allOf:
    > items:
    > - const: pci # PCIe core reset
    >
    > + - if:
    > + properties:
    > + compatible:
    > + contains:
    > + enum:
    > + - qcom,pcie-sm8550-pcie0
    > + then:
    > + properties:
    > + clocks:
    > + minItems: 11
    > + maxItems: 11
    > + clock-names:
    > + items:
    > + - const: pipe # PIPE clock
    > + - const: pipe_mux # PIPE MUX
    > + - const: phy_pipe # PIPE output clock
    > + - const: ref # REFERENCE clock
    > + - const: aux # Auxiliary clock
    > + - const: cfg # Configuration clock
    > + - const: bus_master # Master AXI clock
    > + - const: bus_slave # Slave AXI clock
    > + - const: slave_q2a # Slave Q2A clock
    > + - const: ddrss_sf_tbu # PCIe SF TBU clock
    > + - const: aggre0 # Aggre NoC PCIe0 AXI clock
    > + interconnects:
    > + maxItems: 1
    > + interconnect-names:
    > + const: icc_path

    Keep existing pattern of allOf:if:then or change entire file to a
    different style.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-11-16 14:04    [W:4.143 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site