lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH linux-next] scsi: target: Use sysfs streq instead of strncmp
From: guo ziliang <guo.ziliang@zte.com.cn>
There is a ready-to-use method to compare a retrieved from a sysfs node
string with another string. It treats both NUL and newline-then-NUL as
equivalent string terminations. So use it instead of manually truncating
the line length in the strncmp() method.

Signed-off-by: guo ziliang <guo.ziliang@zte.com.cn>
---
drivers/target/target_core_configfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index f4a220a..3b89d83 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -208,7 +208,7 @@ static struct config_group *target_core_register_fabric(
* mkdir(2) system calls with known TCM fabric modules.
*/

- if (!strncmp(name, "iscsi", 5)) {
+ if (sysfs_streq(name, "iscsi")) {
/*
* Automatically load the LIO Target fabric module when the
* following is called:
@@ -221,7 +221,7 @@ static struct config_group *target_core_register_fabric(
" iscsi_target_mod.ko: %d\n", ret);
return ERR_PTR(-EINVAL);
}
- } else if (!strncmp(name, "loopback", 8)) {
+ } else if (sysfs_streq(name, "loopback")) {
/*
* Automatically load the tcm_loop fabric module when the
* following is called:
--
1.8.3.1
\
 
 \ /
  Last update: 2022-11-17 02:51    [W:0.180 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site