lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings
On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> > From: Suman Anna <s-anna@ti.com>
> >
> > Add DT schema binding for PRU consumers. The binding includes
> > all the common properties that can be used by different PRU consumer
> > or application nodes and supported by the PRU remoteproc driver.
> > These are used to configure the PRU hardware for specific user
> > applications.
> >
> > The application nodes themselves should define their own bindings.
> >
> > Co-developed-by: Tero Kristo <t-kristo@ti.com>
> > Co-developed-by: Suman Anna <s-anna@ti.com>
> > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
> > Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>
> Run checkpatch.pl and fix the warnings with the tags.

My bad - I asked Danish to remove the SoBs to lighten the changelog
presentation. Danish, do you absolutely need to list everyone that touched that
patchset? If so I suppose just listing the SoBs would be a compromise.

>
> You didn't add review/ack tags either.

Those are important.

Please send another patchset that clears checkpatch with review/acks and I'll
look at it.

Thanks,
Mathieu

>
> > ---
> > .../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml

\
 
 \ /
  Last update: 2022-11-16 19:11    [W:0.066 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site