Messages in this thread | | | Subject | Re: [PATCH] ima: Fix misuse of dereference of pointer in template_desc_init_fields() | From | Mimi Zohar <> | Date | Wed, 16 Nov 2022 11:54:01 -0500 |
| |
On Mon, 2022-11-14 at 08:37 +0000, Roberto Sassu wrote: > > From: Xiujianfeng > > Sent: Saturday, November 12, 2022 10:27 AM > > The input parameter @fields is type of struct ima_template_field ***, so > > when allocates array memory for @fields, the size of element should be > > sizeof(**field) instead of sizeof(*field). > > > > Actually the original code would not cause any runtime error, but it's > > better to make it logically right. > > > > Fixes: adf53a778a0a ("ima: new templates management mechanism") > > Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com> > > Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
Thanks, applied.
Mimi
| |