lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 17/39] PCI/MSI: Get rid of externs in msi.h
    On Fri, Nov 11, 2022 at 02:54:42PM +0100, Thomas Gleixner wrote:
    > From: Ahmed S. Darwish <darwi@linutronix.de>
    >
    > Follow the style of <linux/pci.h>
    >
    > Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

    Acked-by: Bjorn Helgaas <bhelgaas@google.com>

    > ---
    > drivers/pci/msi/msi.h | 8 ++++----
    > 1 file changed, 4 insertions(+), 4 deletions(-)
    >
    > --- a/drivers/pci/msi/msi.h
    > +++ b/drivers/pci/msi/msi.h
    > @@ -5,12 +5,12 @@
    >
    > #define msix_table_size(flags) ((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
    >
    > -extern int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
    > -extern void pci_msi_teardown_msi_irqs(struct pci_dev *dev);
    > +int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
    > +void pci_msi_teardown_msi_irqs(struct pci_dev *dev);
    >
    > #ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
    > -extern int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
    > -extern void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev);
    > +int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
    > +void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev);
    > #else
    > static inline int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
    > {
    >

    \
     
     \ /
      Last update: 2022-11-16 17:16    [W:4.557 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site