Messages in this thread | | | Date | Tue, 15 Nov 2022 22:34:13 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH 4/9] dt-bindings: Add RISC-V incoming MSI controller bindings |
| |
On Mon, Nov 14, 2022 at 05:59:00PM +0530, Anup Patel wrote: > On Sun, Nov 13, 2022 at 8:18 PM Conor Dooley <conor@kernel.org> wrote:
> > Also, the file name says "riscv,imsic", the description says "IMSIC" but > > you've used "imsics" in the compatible. Is this a typo, or a plural? > > Yes, the file name should be consistent. I will update the file name.
Is there a reason why the compatible is plural when all of the other mentions etc do not have an "s"? It really did look like a typo to me.
It's the "incoming MSI controller", so I am unsure as to where the "s" actually even comes from. Why not just use "riscv,imsic"?
Thanks, Conor.
| |