Messages in this thread | | | Date | Mon, 14 Nov 2022 20:47:44 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v6 1/1] i2c: Restore initial power state if probe fails |
| |
wOn Mon, Nov 14, 2022 at 01:20:34PM +0100, Ricardo Ribalda wrote: > A driver that supports I2C_DRV_ACPI_WAIVE_D0_PROBE is not expected to > power off a device that it has not powered on previously. > > For devices operating in "full_power" mode, the first call to > `i2c_acpi_waive_d0_probe` will return 0, which means that the device > will be turned on with `dev_pm_domain_attach`. > > If probe fails the second call to `i2c_acpi_waive_d0_probe` will > return 1, which means that the device will not be turned off. > This is, it will be left in a different power state. Lets fix it. > > Reviewed-by: Hidenori Kobayashi <hidenorik@chromium.org> > Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: stable@vger.kernel.org > Fixes: b18c1ad685d9 ("i2c: Allow an ACPI driver to manage the device's power state during probe") > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Applied to for-current, thanks!
[unhandled content-type:application/pgp-signature] | |