Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH v2 2/2] gpiolib: of: Drop redundant check in of_mm_gpiochip_remove() | Date | Mon, 14 Nov 2022 20:46:26 +0200 |
| |
The callers never call the function with invalid pointer. Moreover, compiler quite likely dropped that check anyway because we use that pointer before the check.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- v2: added tags (Linus, Dmitry) drivers/gpio/gpiolib-of.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index d30a5210dfdd..f96cb6fe6831 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -962,9 +962,6 @@ void of_mm_gpiochip_remove(struct of_mm_gpio_chip *mm_gc) { struct gpio_chip *gc = &mm_gc->gc; - if (!mm_gc) - return; - gpiochip_remove(gc); iounmap(mm_gc->regs); kfree(gc->label); -- 2.35.1
| |