lkml.org 
[lkml]   [2022]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] gpiolib: of: Use correct fwnode for DT-probed chips
    On Fri, Nov 11, 2022 at 12:37:32PM +0100, Thierry Reding wrote:
    > From: Thierry Reding <treding@nvidia.com>
    >
    > The OF node store in chip->fwnode is used to explicitly override the FW
    > node for a GPIO chip. For chips that use the default FW node (i.e. that
    > of their parent device), this will be NULL and cause the chip not to be
    > fully registered.
    >
    > Instead, use the GPIO device's FW node, which is set to either the node
    > of the parent device or the explicit override in chip->fwnode.
    >
    > Fixes: 8afe82550240 ("gpiolib: of: Prepare of_gpiochip_add() / of_gpiochip_remove() for fwnode")
    > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
    > Signed-off-by: Thierry Reding <treding@nvidia.com>

    Reviewed-by: Brian Masney <bmasney@redhat.com>
    Tested-by: Brian Masney <bmasney@redhat.com>

    I separately sent a similar type of patch to fix the same issue today:
    https://lore.kernel.org/linux-arm-msm/20221114202943.2389489-1-bmasney@redhat.com/T/#u

    I'm still not sure what caused this breakage in linux-next.

    Brian

    \
     
     \ /
      Last update: 2022-11-14 22:16    [W:4.187 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site