Messages in this thread | | | Date | Fri, 11 Nov 2022 20:14:44 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 3/4] sched: add sched_numa_find_nth_cpu() |
| |
On Fri, Nov 11, 2022 at 09:07:15AM -0800, Yury Norov wrote: > On Fri, Nov 11, 2022 at 01:42:29PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 10, 2022 at 08:00:26PM -0800, Yury Norov wrote:
...
> > > +out: > > > > out_unlock: ? > > Do you think it's better?
Yes. It shows what will happen at goto.
So when one reads the "goto out;" it's something like "return ret;". But "goto out_unlock;" immediately pictures "unlock; return ret;".
P.S. That's basically the way how we name labels.
> > > + rcu_read_unlock(); > > > + return ret;
-- With Best Regards, Andy Shevchenko
| |