lkml.org 
[lkml]   [2022]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH 0/1] sched/pelt: Change PELT halflife at runtime
From
On 07/11/2022 14:41, Peter Zijlstra wrote:
> On Thu, Sep 29, 2022 at 03:41:47PM +0100, Kajetan Puchalski wrote:

[...]

> @@ -2956,13 +2958,26 @@ static inline unsigned long cpu_util_dl(struct rq *rq)
> */
> static inline unsigned long cpu_util_cfs(int cpu)
> {
> + struct rq *rq = cpu_rq(cpu);
> struct cfs_rq *cfs_rq;
> unsigned long util;
>
> - cfs_rq = &cpu_rq(cpu)->cfs;
> + cfs_rq = &rq->cfs;
> util = READ_ONCE(cfs_rq->avg.util_avg);
>
> if (sched_feat(UTIL_EST)) {
> + if (sched_feat(UTIL_EST_FASTER)) {
> + struct task_struct *curr;
> +
> + rcu_read_lock();
> + curr = rcu_dereference(rq->curr);
> + if (likely(curr->sched_class == &fair_sched_class)) {
> + u64 runtime = curr->se.sum_exec_runtime - curr->se.exec_start;

Don't we and up with gigantic runtime numbers here?

oot@juno:~# cat /proc/1676/task/1676/schedstat
36946300 1150620 11
root@juno:~# cat /proc/1676/task/1676/sched
rt-app (1676, #threads: 2)
-------------------------------------------------------------------
se.exec_start : 77766.964240 <- !
se.vruntime : 563.587883
e.sum_exec_runtime : 36.946300 <- !
se.nr_migrations : 0
...

I expect cpu_util_cfs() to be ~1024 almost all the time now.

> + util = max_t(unsigned long, util,
> + faster_est_approx(runtime * 2));
> + }
> + rcu_read_unlock();
> + }
> util = max_t(unsigned long, util,
> READ_ONCE(cfs_rq->avg.util_est.enqueued));
> }

[...]

\
 
 \ /
  Last update: 2022-11-10 12:17    [W:0.113 / U:3.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site