Messages in this thread | | | Date | Thu, 10 Nov 2022 08:02:36 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic CS48L31/32/33 codecs |
| |
On Wed, 09 Nov 2022 16:53:28 +0000, Richard Fitzgerald <rf@opensource.cirrus.com> wrote: > > The Cirrus Logic CS48L31/32/33 audio codecs contain a programmable > interrupt controller with a variety of interrupt sources, including > GPIOs that can be used as interrupt inputs. > > This driver provides the handling for the interrupt controller. As the > codec is accessed via regmap, the generic regmap_irq functionality > is used to do most of the work. >
I cannot spot a shred of interrupt controller code in there. This belongs IMO to the MFD code. It is also a direct copy of the existing irq-madera.c code, duplicated for no obvious reason.
M.
-- Without deviation from the norm, progress is not possible.
| |