lkml.org 
[lkml]   [2022]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller binding to yaml
From
On 08/10/2022 04:57, Chunyan Zhang wrote:
>>> + eic_debounce: gpio@40210000 {
>>> + compatible = "sprd,sc9860-eic-debounce";
>>> + reg = <0 0x40210000 0 0x80>;
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <2>;
>>> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
>>> + };
>>> + };
>>> +
>>> + sc2730_pmic {
>>
>> If you insisted to keep it, at least should be correct, so just pmic.
>>
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + pmic_eic: gpio@300 {
>>
>> It's exactly the same example as above - all same properties. Drop it or
>> bring some differences.
>
> The differences are on #address-cells and #size-cells.
>

Which don't really matter...

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-10-09 17:17    [W:0.048 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site