Messages in this thread | | | Date | Fri, 7 Oct 2022 19:40:36 +0300 | Subject | Re: [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation | From | Gwan-gyeong Mun <> |
| |
Linus and Kees, I also understood that I should not make and use the macro that performs assignment and checking at the same time, and I will drop it and update it.
Kees, the overflows_type() macro had several updates as input from you and the community, and there is an advantage when moving to Linux common. What are your thoughts on continuing to add the overflows_type() macro to overflows.h?
Br,
G.G.
On 9/28/22 9:06 PM, Kees Cook wrote: > On Wed, Sep 28, 2022 at 10:09:04AM -0700, Linus Torvalds wrote: >> Kees, you need to reign in the craziness in overflow.h. > > Understood. I've been trying to help the drm folks walk a line between > having a bunch of custom macros hidden away in the drm includes and > building up generalized versions that are actually helpful beyond drm. > But I can see that it doesn't help to have a "do two things at the same > time" macro for the assignment checking. >
| |