Messages in this thread | | | From | Emil Renner Berthing <> | Date | Wed, 5 Oct 2022 15:31:59 +0200 | Subject | Re: [PATCH v1 26/30] pinctrl: starfive: Add StarFive JH7110 driver |
| |
On Tue, 4 Oct 2022 at 10:57, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Sep 30, 2022 at 9:45 AM Hal Feng > <hal.feng@linux.starfivetech.com> wrote: > > > From: Jianlong Huang <jianlong.huang@starfivetech.com> > > > > Add pinctrl driver for StarFive JH7110 SoC. > > > > Signed-off-by: Jianlong Huang <jianlong.huang@starfivetech.com> > > Signed-off-by: Hal Feng <hal.feng@linux.starfivetech.com> > > Since Emil submitted the first driver I would really appreciate his review > on this version.
I tried really hard to come up with a good way to share code between the JH7100 and JH7110 drivers, but so many details different on the JH7110 that it's probably best to just have a separate driver, so that part is fine.
As mentioned elsewhere this driver certainly shouldn't be accepted without following the generic pinctrl and pinmux bindings. You can see the driver I wrote here: https://github.com/esmil/linux/commit/c2633315385fef1a25aa3711facef07d915820e1
It is certainly not perfect and far from complete, but at least it does follow the generic bindings. Feel free to copy all or parts of that.
/Emil
> > Yours, > Linus Walleij > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
| |