Messages in this thread | | | Date | Thu, 27 Oct 2022 10:25:37 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3 01/15] perf/mem: Introduce PERF_MEM_LVLNUM_{EXTN_MEM|IO} |
| |
On Sat, Oct 01, 2022 at 12:07:40PM +0530, Ravi Bangoria wrote:
> From 5deb2055e2b5b0a61403f2d5f4e5a784b14a65e3 Mon Sep 17 00:00:00 2001 > From: Ravi Bangoria <ravi.bangoria@amd.com> > Date: Sat, 1 Oct 2022 11:37:05 +0530 > Subject: [PATCH] perf/mem: Rename PERF_MEM_LVLNUM_EXTN_MEM to > PERF_MEM_LVLNUM_CXL > > PERF_MEM_LVLNUM_EXTN_MEM was introduced to cover CXL devices but it's > bit ambiguous name and also not generic enough to cover cxl.cache and > cxl.io devices. Rename it to PERF_MEM_LVLNUM_CXL to be more specific. > > Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
Thanks!
> --- > arch/x86/events/amd/ibs.c | 2 +- > include/uapi/linux/perf_event.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c > index 3271735f0070..4cb710efbdd9 100644 > --- a/arch/x86/events/amd/ibs.c > +++ b/arch/x86/events/amd/ibs.c > @@ -801,7 +801,7 @@ static void perf_ibs_get_mem_lvl(union ibs_op_data2 *op_data2, > /* Extension Memory */ > if (ibs_caps & IBS_CAPS_ZEN4 && > ibs_data_src == IBS_DATA_SRC_EXT_EXT_MEM) { > - data_src->mem_lvl_num = PERF_MEM_LVLNUM_EXTN_MEM; > + data_src->mem_lvl_num = PERF_MEM_LVLNUM_CXL; > if (op_data2->rmt_node) { > data_src->mem_remote = PERF_MEM_REMOTE_REMOTE; > /* IBS doesn't provide Remote socket detail */ > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index 85be78e0e7f6..eb1090604d53 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -1337,7 +1337,7 @@ union perf_mem_data_src { > #define PERF_MEM_LVLNUM_L3 0x03 /* L3 */ > #define PERF_MEM_LVLNUM_L4 0x04 /* L4 */ > /* 5-0x8 available */ > -#define PERF_MEM_LVLNUM_EXTN_MEM 0x09 /* Extension memory */ > +#define PERF_MEM_LVLNUM_CXL 0x09 /* CXL */ > #define PERF_MEM_LVLNUM_IO 0x0a /* I/O */ > #define PERF_MEM_LVLNUM_ANY_CACHE 0x0b /* Any cache */ > #define PERF_MEM_LVLNUM_LFB 0x0c /* LFB */ > -- > 2.31.1
| |