Messages in this thread | | | From | CK Hu (胡俊光) <> | Subject | Re: [PATCH v8, 2/4] mailbox: mtk-cmdq: instead magic number with GCE_CTRL_BY_SW | Date | Mon, 3 Oct 2022 03:56:10 +0000 |
| |
Hi, Yongqiang:
On Sat, 2022-10-01 at 00:06 +0800, Yongqiang Niu wrote: > instead magic number with GCE_CTRL_BY_SW
This is a cleanup patch and I would like the cleanup patch to be the first patch of this series because the cleanup patch could be applied independently.
Regards, CK
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > index 88db6b4642db..04eb44d89119 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -133,7 +133,7 @@ static void cmdq_init(struct cmdq *cmdq) > > WARN_ON(clk_bulk_enable(cmdq->gce_num, cmdq->clocks)); > if (cmdq->control_by_sw) > - writel(0x7, cmdq->base + GCE_GCTL_VALUE); > + writel(GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE); > > if (cmdq->sw_ddr_en) > writel(GCE_DDR_EN | GCE_CTRL_BY_SW, cmdq->base + > GCE_GCTL_VALUE);
| |