Messages in this thread | | | Date | Fri, 14 Oct 2022 13:45:41 -0700 | Subject | Re: [PATCH v2 1/2] scsi: ufs: core: Remove unnecessary if statement | From | Bart Van Assche <> |
| |
On 10/14/22 13:30, Bean Huo wrote: > I double-checked the changelog and the stack overflow issue was double > fixed by your commit: > > commit d3d9c4570285 ("scsi: ufs: Fix memory corruption by > ufshcd_read_desc_param()"), > > For example, if the user wants to read wb_buf_alloc_units in the RPMB > unit descriptor, > > parameter offset = 41, parameter size = 4, > buff_len = 45; > > After ufshcd_query_descriptor_retry(), buff_len will be updated to 35. > > param_offset > buff_len, then -EINVAL will be returned. > > So we can safely remove this check, and if you still have concerns, I > can verify when I get back to the office.
Hi Bean,
Thank you for having looked this up. I agree with the above.
Bart.
| |