Messages in this thread | | | Date | Fri, 14 Oct 2022 11:03:30 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH V2 1/2] net: Fixup netif_attrmask_next_and warning |
| |
On Fri, 14 Oct 2022 09:16:01 -0700 Yury Norov wrote: > > We will not be merging a refactoring series into net to silence an > > arguably over-eager warning. We need a minimal fix, Guo Ren's patches > > seem to miss the mark so I reckon the best use of everyone's time is > > to just drop the exposing patch and retry in -next 🤷 > > If you prefer treating symptoms rather than the disease - I have nothing > to add.
I don't, but we may consider different things to be "the disease". Please do not insinuate that I don't care about fixing bugs.
What I can grok from the history and your commit messages is that you want to catch people who pass what you consider invalid inputs to the helpers, but nothing will crash/OOB access here, because the helper double checks that the input is < nr_bits.
So it's a nice cleanup and refactoring, sure, but not an urgent fix that needs to go to Linus ASAP.
If that's not what you're fixing please explain, I believe I already asked you to clarify before. And the commit message aren't exactly informative either.
| |