lkml.org 
[lkml]   [2022]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf annotate: Add missing condition flags for arm64
Em Thu, Oct 06, 2022 at 03:22:32PM -0700, Namhyung Kim escreveu:
> According to the document [1], it can also have 'hs', 'lo', 'vc', 'vs' as a
> condition code. Let's add them too.
>
> [1] https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/condition-codes-1-condition-flags-and-codes

Thanks, applied.

- Arnaldo


> Reported-by: Kevin Nomura <nomurak@google.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/arch/arm64/annotate/instructions.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/arm64/annotate/instructions.c b/tools/perf/arch/arm64/annotate/instructions.c
> index 037e292ecd8e..4af0c3a0f86e 100644
> --- a/tools/perf/arch/arm64/annotate/instructions.c
> +++ b/tools/perf/arch/arm64/annotate/instructions.c
> @@ -102,7 +102,7 @@ static int arm64__annotate_init(struct arch *arch, char *cpuid __maybe_unused)
> if (err)
> goto out_free_arm;
> /* b, b.cond, br, cbz/cbnz, tbz/tbnz */
> - err = regcomp(&arm->jump_insn, "^[ct]?br?\\.?(cc|cs|eq|ge|gt|hi|le|ls|lt|mi|ne|pl)?n?z?$",
> + err = regcomp(&arm->jump_insn, "^[ct]?br?\\.?(cc|cs|eq|ge|gt|hi|hs|le|lo|ls|lt|mi|ne|pl|vc|vs)?n?z?$",
> REG_EXTENDED);
> if (err)
> goto out_free_call;
> --
> 2.38.0.rc1.362.ged0d419d3c-goog

--

- Arnaldo

\
 
 \ /
  Last update: 2022-10-14 15:48    [W:0.044 / U:4.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site