Messages in this thread | | | Date | Tue, 11 Oct 2022 09:45:12 +0200 | From | Marijn Suijten <> | Subject | Re: [PATCH v2 10/16] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema |
| |
On 2022-09-30 21:29:48, Krzysztof Kozlowski wrote: > DT schema expects TLMM pin configuration nodes to be named with > '-state' suffix and their optional children with '-pins' suffix. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks!
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Perhaps mention more clearly that this is fixing up an earlier patch that tried to address missing `-pins`?
- Marijn
> --- > arch/arm64/boot/dts/qcom/sm6125.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi > index 1fe3fa3ad877..af49a748e511 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi > @@ -407,13 +407,13 @@ data-pins { > }; > > sdc2_on_state: sdc2-on-state { > - clk { > + clk-pins { > pins = "sdc2_clk"; > drive-strength = <16>; > bias-disable; > }; > > - cmd-pins-pins { > + cmd-pins { > pins = "sdc2_cmd"; > drive-strength = <10>; > bias-pull-up; > -- > 2.34.1 >
| |