lkml.org 
[lkml]   [2022]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services
From

On 10/3/2022 12:01 AM, Jiri Slaby wrote:
> On 28. 09. 22, 21:56, Elliot Berman wrote:
>> +struct rm_cons_port {
>> +    struct tty_port port;
>> +    u16 vmid;
>> +    bool open;
>> +    unsigned int index;
>> +
>> +    DECLARE_KFIFO(put_fifo, char, 1024);
>
> Why is tty_port::xmit_fifo not enough?
>

xmit_fifo gave me some inspiration to avoid using KFIFO here and skip
extra an extra memcpy into/out of the FIFO.

I've also dropped out the FIFO usage for tty_operations and this
buffering is only used for printk console.

Thanks,
Elliot

\
 
 \ /
  Last update: 2022-10-10 20:07    [W:0.152 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site