lkml.org 
[lkml]   [2022]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] tpm: st33zp24: drop support for platform data
On Fri, Sep 30, 2022 at 11:39:06PM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 25, 2022 at 10:39:56PM -0700, Dmitry Torokhov wrote:
> > There are no users of st33zp24_platform_data in mainline, and new boards
> > should be using device tree or ACPI to describe resources, so let's drop
> > support for platform data from the driver.
>
> Nit: drop instead of let's drop (needs also different sentence structure
> obviously).

OK.

>
> Also, please leave predictions out, or back them up with data. It's good
> enough reason to remove code, if it is not used for anything. I really
> don't care about "should" part. It is is out-of-scope for a kernel
> patch.

This is not a prediction, but a statement. The idea I was trying to
express is that platform data is needed for legacy boards, those that
predate device tree and/or ACPI support. Therefore there will be no
new users of it appearing in the kernel, as we will not accept a new
board/architecture it using wither ACPI or DT.

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2022-10-01 06:11    [W:0.055 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site