lkml.org 
[lkml]   [2022]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bcache: use default_groups in kobj_type
On Sat, Jan 08, 2022 at 02:16:28PM +0800, Coly Li wrote:
> On 1/6/22 6:00 PM, Greg Kroah-Hartman wrote:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the bcache sysfs code to use default_groups field which has
> > been the preferred way since aa30f47cf666 ("kobject: Add support for
> > default attribute groups to kobj_type") so that we can soon get rid of
> > the obsolete default_attrs field.
> >
> > Cc: Coly Li <colyli@suse.de>
> > Cc: Kent Overstreet <kent.overstreet@gmail.com>
> > Cc: linux-bcache@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> It looks good to me.
>
> Acked-by: Coly Li <colyli@suse.de>
>
> I assume you may take this patch directly in your maintenance path, but if
> you want me to take this, just let me know. Thanks.

I can take it myself, or you can, which ever is easiest for you, just
let me know which you prefer. Thanks for the review!

greg k-h

\
 
 \ /
  Last update: 2022-01-08 09:32    [W:0.068 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site