Messages in this thread | | | Date | Sat, 8 Jan 2022 09:31:29 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] bcache: use default_groups in kobj_type |
| |
On Sat, Jan 08, 2022 at 02:16:28PM +0800, Coly Li wrote: > On 1/6/22 6:00 PM, Greg Kroah-Hartman wrote: > > There are currently 2 ways to create a set of sysfs files for a > > kobj_type, through the default_attrs field, and the default_groups > > field. Move the bcache sysfs code to use default_groups field which has > > been the preferred way since aa30f47cf666 ("kobject: Add support for > > default attribute groups to kobj_type") so that we can soon get rid of > > the obsolete default_attrs field. > > > > Cc: Coly Li <colyli@suse.de> > > Cc: Kent Overstreet <kent.overstreet@gmail.com> > > Cc: linux-bcache@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > It looks good to me. > > Acked-by: Coly Li <colyli@suse.de> > > I assume you may take this patch directly in your maintenance path, but if > you want me to take this, just let me know. Thanks.
I can take it myself, or you can, which ever is easiest for you, just let me know which you prefer. Thanks for the review!
greg k-h
| |