lkml.org 
[lkml]   [2022]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] staging: r8188eu: change functions to return void
Hello Greg,

On Thu, Jan 06, 2022 at 06:58:50PM +0100, Greg KH wrote:
> On Thu, Jan 06, 2022 at 11:11:52PM +0530, Abdun Nihaal wrote:
> > Some functions in ioctl_linux.c always returns 0 and their return values
> > are never used. Change return type of such functions to void.
> >
> > While at it, align function arguments with open parenthesis to fix
> > checkpatch checks.
> >
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
>
> Are you sure that checkpatch allowed this change?

Yes, I ran checkpatch on both the patches and found no errors, warnings
or checks. Is there something that needs to be fixed?

Regards,
Abdun Nihaal

\
 
 \ /
  Last update: 2022-01-07 07:52    [W:0.060 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site