Messages in this thread | | | From | Miles Chen <> | Subject | Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning | Date | Fri, 7 Jan 2022 09:40:46 +0800 |
| |
Hi Matthias,
>> I'm still not happy with the commit subject, I think it is misleading. Clang >> only helped to find the bug, but the we are fixing something else, that's not >> just a clang warning. But I don't want to nit-pick too much so: >> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> thanks. I think you are right. > I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the > clang part and submit patch v4.
I posted patch v4 https://lore.kernel.org/linux-mediatek/20220103054706.8072-1-miles.chen@mediatek.com/ without your reviewed-by tag.
Would you mind taking a look at the patch?
Miles
| |