lkml.org 
[lkml]   [2022]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 08/24] ARM: dts: exynos: simplify PMIC DVS pin configuration in Peach Pi
Hi Krzysztof,

On Sat, Jan 1, 2022 at 1:15 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The pin configuration for PMIC DVS (pmic-dvs-2 and pmic-dvs-3) are
> exactly the same, so merge them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 20 +++++++-------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 6bf3fd37fb2b..eca805b83816 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -221,7 +221,7 @@ max77802: pmic@9 {
> interrupts = <1 IRQ_TYPE_NONE>;
> pinctrl-names = "default";
> pinctrl-0 = <&max77802_irq>, <&pmic_selb>,
> - <&pmic_dvs_1>, <&pmic_dvs_2>, <&pmic_dvs_3>;
> + <&pmic_dvs_1>, <&pmic_dvs_2>;
> wakeup-source;
> reg = <0x9>;
> #clock-cells = <1>;
> @@ -874,26 +874,20 @@ &sd1_cmd {
>
> &pinctrl_2 {
> pmic_dvs_2: pmic-dvs-2 {
> - samsung,pins = "gpj4-2";
> + samsung,pins = "gpj4-2", "gpj4-3";
> samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
> };
> +};
>
> - pmic_dvs_3: pmic-dvs-3 {
> - samsung,pins = "gpj4-3";
> - samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> - samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
> - };
> +/* pinctrl_3*/
> +/* Drive SPI lines at x2 for better integrity */
> +&spi2_bus {
> + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> };
>
Maybe move this spi2_bus part to patch #07 as the commit does not
mention this change.

> &pinctrl_3 {
> - /* Drive SPI lines at x2 for better integrity */
> - spi2-bus {
> - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
> - };
> -
> /* Drive SPI chip select at x2 for better integrity */
> ec_spi_cs: ec-spi-cs {
> samsung,pins = "gpb1-2";
> --
> 2.32.0
>


--
Regards,
Alim

\
 
 \ /
  Last update: 2022-01-06 19:48    [W:0.159 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site