lkml.org 
[lkml]   [2022]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] null_blk: Use bitmap_zalloc() when applicable
On Thu, Dec 30, 2021 at 11:28:28AM +0900, Damien Le Moal wrote:
> >
> > - tag_size = ALIGN(nq->queue_depth, BITS_PER_LONG) / BITS_PER_LONG;
> > - nq->tag_map = kcalloc(tag_size, sizeof(unsigned long), GFP_KERNEL);
> > + nq->tag_map = bitmap_zalloc(nq->queue_depth, GFP_KERNEL);
> > if (!nq->tag_map) {
> > kfree(nq->cmds);
> > return -ENOMEM;
>
> Before this patch, tag_size would always be a multiple of BITS_PER_LONG.
> Using bitmap_zalloc(), that alignment goes away, but I think this is OK.
>

It's still going to be a multiple of long. Bitmaps are always stored
in longs.

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-01-06 08:45    [W:0.072 / U:1.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site