lkml.org 
[lkml]   [2022]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] cpufreq: amd-pstate: Fix the dependence issue of AMD P-State
On Thu, Jan 6, 2022 at 8:43 AM Huang Rui <ray.huang@amd.com> wrote:
>
> The AMD P-State driver is based on ACPI CPPC function, so ACPI should be
> dependence of this driver in the kernel config.
>
> In file included from ../drivers/cpufreq/amd-pstate.c:40:0:
> ../include/acpi/processor.h:226:2: error: unknown type name ‘phys_cpuid_t’
> phys_cpuid_t phys_id; /* CPU hardware ID such as APIC ID for x86 */
> ^~~~~~~~~~~~
> ../include/acpi/processor.h:355:1: error: unknown type name ‘phys_cpuid_t’; did you mean ‘phys_addr_t’?
> phys_cpuid_t acpi_get_phys_id(acpi_handle, int type, u32 acpi_id);
> ^~~~~~~~~~~~
> phys_addr_t
> CC drivers/rtc/rtc-rv3029c2.o
> ../include/acpi/processor.h:356:1: error: unknown type name ‘phys_cpuid_t’; did you mean ‘phys_addr_t’?
> phys_cpuid_t acpi_map_madt_entry(u32 acpi_id);
> ^~~~~~~~~~~~
> phys_addr_t
> ../include/acpi/processor.h:357:20: error: unknown type name ‘phys_cpuid_t’; did you mean ‘phys_addr_t’?
> int acpi_map_cpuid(phys_cpuid_t phys_id, u32 acpi_id);
> ^~~~~~~~~~~~
> phys_addr_t
>
> See https://lore.kernel.org/lkml/20e286d4-25d7-fb6e-31a1-4349c805aae3@infradead.org/.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/cpufreq/Kconfig.x86 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86
> index a951768c3ebb..55516043b656 100644
> --- a/drivers/cpufreq/Kconfig.x86
> +++ b/drivers/cpufreq/Kconfig.x86
> @@ -36,9 +36,9 @@ config X86_PCC_CPUFREQ
>
> config X86_AMD_PSTATE
> tristate "AMD Processor P-State driver"
> - depends on X86
> - select ACPI_PROCESSOR if ACPI
> - select ACPI_CPPC_LIB if X86_64 && ACPI
> + depends on X86 && ACPI
> + select ACPI_PROCESSOR
> + select ACPI_CPPC_LIB if X86_64
> select CPU_FREQ_GOV_SCHEDUTIL if SMP
> help
> This driver adds a CPUFreq driver which utilizes a fine grain
> --

Applied (under a modified subject), thanks!

\
 
 \ /
  Last update: 2022-01-06 18:35    [W:0.093 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site