Messages in this thread | | | Subject | Re: [PATCH v2 12/35] brcmfmac: pcie: Fix crashes due to early IRQs | From | Hector Martin <> | Date | Thu, 6 Jan 2022 22:10:45 +0900 |
| |
On 04/01/2022 23.12, Andy Shevchenko wrote: > On Tue, Jan 4, 2022 at 9:29 AM Hector Martin <marcan@marcan.st> wrote: >> >> The driver was enabling IRQs before the message processing was >> initialized. This could cause IRQs to come in too early and crash the >> driver. Instead, move the IRQ enable and hostready to a bus preinit >> function, at which point everything is properly initialized. >> >> Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.") > > You should gather fixes at the beginning of the series, and even > possible to send them as a separate series. In the current state it's > unclear if there are dependencies on your new feature (must not be for > fixes that meant to be backported). >
Thanks, I wasn't sure what order you wanted those in. I'll put them at the top for v3. I think none of those should have any dependencies on the rest of the patches, modulo some trivial rebase wrangling.
-- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub
| |