Messages in this thread | | | Date | Thu, 6 Jan 2022 14:04:39 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: magicmouse: Fix an error handling path in magicmouse_probe() |
| |
On Tue, 28 Dec 2021, Christophe JAILLET wrote:
> If the timer introduced by the commit below is started, then it must be > deleted in the error handling of the probe. Otherwise it would trigger > once the driver is no more. > > Fixes: 0b91b4e4dae6 ("HID: magicmouse: Report battery level over USB") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/hid/hid-magicmouse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c > index eba1e8087bfd..b8b08f0a8c54 100644 > --- a/drivers/hid/hid-magicmouse.c > +++ b/drivers/hid/hid-magicmouse.c > @@ -873,6 +873,7 @@ static int magicmouse_probe(struct hid_device *hdev, > > return 0; > err_stop_hw: > + del_timer_sync(&msc->battery_timer); > hid_hw_stop(hdev); > return ret; > }
Applied, thanks.
-- Jiri Kosina SUSE Labs
| |