Messages in this thread | | | Subject | Re: [PATCH v5 01/14] iommu: Add dma ownership management interfaces | From | Lu Baolu <> | Date | Thu, 6 Jan 2022 11:47:50 +0800 |
| |
On 1/5/22 12:41 AM, Bjorn Helgaas wrote: >>> Devices under kernel drivers control must call iommu_device_use_dma_api() >>> before driver probes. The driver binding process must be aborted if it >>> returns failure. > "Devices" don't call functions. Drivers do, or in this case, it looks > like the bus DMA code (platform, amba, fsl, pci, etc). > > These functions are EXPORT_SYMBOL_GPL(), but it looks like all the > callers are built-in, so maybe the export is unnecessary?
Yes. If all callers are built-in, we can remove this export.
> > You use "iommu"/"IOMMU" and "dma"/"DMA" interchangeably above. Would > be easier to read if you picked one. >
I should cleanup all these. I also realized that I forgot to cleanup some typos you pointed out in v4:
https://lore.kernel.org/linux-iommu/20211229211626.GA1701512@bhelgaas/
Sorry about it. I will take care of all these in the next version.
Best regards, baolu
| |