lkml.org 
[lkml]   [2022]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier()
From
Date
Hi Jason,

On 1/4/22 8:48 PM, Jason Gunthorpe wrote:
> On Tue, Jan 04, 2022 at 09:56:30AM +0800, Lu Baolu wrote:
>
>> v5:
>> - Move kernel dma ownership auto-claiming from driver core to bus
>> callback. (Greg)
>> - Refactor the iommu interfaces to make them more specific.
>> (Jason/Robin)
>> - Simplify the dma ownership implementation by removing the owner
>> type. (Jason)
>> - Commit message refactoring for PCI drivers. (Bjorn)
>> - Move iommu_attach/detach_device() improvement patches into another
>> series as there are a lot of code refactoring and cleanup staffs
>> in various device drivers.
>
> Since you already have the code you should make this 'other series'
> right now. It should delete iommu_group_attach() and fix
> iommu_device_attach().

Yes. I am doing the functional and compile tests. I will post it once I
complete the testing.

>
> You also didn't really do my suggestion, this messes up the normal
> __iommu_attach_group()/__iommu_detach_group() instead of adding the
> clear to purpose iommu_replace_group() for VFIO to use. This just
> makes it more difficult to normalize the APIs.

I didn't forget that. :-) It's part of the new series.

>
> Otherwise it does seem to have turned out to be more understandable.
>
> Jason
>

Best regards,
baolu

\
 
 \ /
  Last update: 2022-01-05 07:53    [W:0.366 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site