lkml.org 
[lkml]   [2022]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] can: gs_usb: Zero-initialize flags
Date
No information is deliberately sent here in host->device communications,
but the open-source candleLight firmware echoes it back, which can
result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
spurious ERRORFRAMEs.

Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
---
drivers/net/can/usb/gs_usb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 1b400de00f51..cc4ad8d59bd7 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -507,6 +507,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,

hf->echo_id = idx;
hf->channel = dev->channel;
+ hf->flags = 0;

cf = (struct can_frame *)skb->data;

base-commit: d2f38a3c6507b2520101f9a3807ed98f1bdc545a
--
2.20.1

\
 
 \ /
  Last update: 2022-01-06 01:30    [W:0.036 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site