lkml.org 
[lkml]   [2022]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/4] media: davinci: vpif: drop probe printk
Hi Johan,

Thank you for the patch.

On Wed, Dec 22, 2021 at 2:20 PM Johan Hovold <johan@kernel.org> wrote:
>
> Drivers should generally not print anything for a successful probe, and
> printing "success" before probe is done makes no sense.
>
> Drop the unnecessary and misleading dev_info() call from probe.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/media/platform/davinci/vpif.c | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> index 4a260f4ed236..03b4e51bb13a 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -456,8 +456,6 @@ static int vpif_probe(struct platform_device *pdev)
> pm_runtime_enable(&pdev->dev);
> pm_runtime_get(&pdev->dev);
>
> - dev_info(&pdev->dev, "vpif probe success\n");
> -
> /*
> * If VPIF Node has endpoints, assume "new" DT support,
> * where capture and display drivers don't have DT nodes
> --
> 2.32.0
>

\
 
 \ /
  Last update: 2022-01-04 19:32    [W:0.150 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site