Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 4 Jan 2022 16:48:35 +0200 | Subject | Re: [PATCH v4] soc: ti: smartreflex: Use platform_get_irq_optional() to get the interrupt |
| |
On Tue, Jan 4, 2022 at 3:45 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq_optional(). > > While at it return 0 instead of returning ret in the probe success path.
...
> + ret = platform_get_irq_optional(pdev, 0); > + if (ret < 0 && ret != -ENXIO) {
> + dev_err_probe(&pdev->dev, ret, "%s: failed to get IRQ resource\n", __func__); > + return ret;
return dev_err_probe(...); ?
> + }
-- With Best Regards, Andy Shevchenko
| |