Messages in this thread | | | Date | Tue, 4 Jan 2022 11:51:58 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] EDAC: use proper list of struct attribute for attributes |
| |
On Tue, Jan 04, 2022 at 11:38:21AM +0100, Greg Kroah-Hartman wrote: > The edac sysfs code is doing some crazy casting of the list of > attributes that is not necessary at all. Instead, properly point to the > correct attribute structure in the lists, which removes the need to cast > anything and the code is now properly typesafe (as much as sysfs > attribute logic is typesafe...) > > Cc: Borislav Petkov <bp@alien8.de> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Tony Luck <tony.luck@intel.com> > Cc: James Morse <james.morse@arm.com> > Cc: Robert Richter <rric@kernel.org> > Cc: linux-edac@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/edac/edac_device_sysfs.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-)
Ick, I forgot the other users like edac_pci_sysfs.c that also has this issue, so let me go fix up this series to include that at the same time. Sorry for the noise here...
thanks,
greg k-h
| |