lkml.org 
[lkml]   [2022]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/34] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips
From
On 2021/12/30 1:42, Mark Kettenis wrote:
>> From: Hector Martin <marcan@marcan.st>
>> Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
>> Alyssa Rosenzweig <alyssa@rosenzweig.io>,
>> Mark Kettenis <kettenis@openbsd.org>,
>> Rafał Miłecki <zajec5@gmail.com>,
>> Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
>> Linus Walleij <linus.walleij@linaro.org>,
>> Hans de Goede <hdegoede@redhat.com>,
>> "John W. Linville" <linville@tuxdriver.com>,
>> "Daniel (Deognyoun) Kim" <dekim@broadcom.com>,
>> "brian m. carlson" <sandals@crustytoothpaste.net>,
>> linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
>> devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
>> linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com,
>> SHA-cyfmac-dev-list@infineon.com
>> Date: Mon, 27 Dec 2021 00:35:51 +0900
>>
>> This binding is currently used for SDIO devices, but these chips are
>> also used as PCIe devices on DT platforms and may be represented in the
>> DT. Re-use the existing binding and add chip compatibles used by Apple
>> T2 and M1 platforms (the T2 ones are not known to be used in DT
>> platforms, but we might as well document them).
>>
>> Then, add properties required for firmware selection and calibration on
>> M1 machines.
>>
>> Signed-off-by: Hector Martin <marcan@marcan.st>
>> ---
>> .../net/wireless/brcm,bcm4329-fmac.yaml | 32 +++++++++++++++++--
>> 1 file changed, 29 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> index c11f23b20c4c..2530ff3e7b90 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> @@ -4,7 +4,7 @@
>> $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> -title: Broadcom BCM4329 family fullmac wireless SDIO devices
>> +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices
>>
>> maintainers:
>> - Arend van Spriel <arend@broadcom.com>
>> @@ -36,16 +36,22 @@ properties:
>> - brcm,bcm43455-fmac
>> - brcm,bcm43456-fmac
>> - brcm,bcm4354-fmac
>> + - brcm,bcm4355c1-fmac
>> - brcm,bcm4356-fmac
>> - brcm,bcm4359-fmac
>> + - brcm,bcm4364b2-fmac
>> + - brcm,bcm4364b3-fmac
>> + - brcm,bcm4377b3-fmac
>> + - brcm,bcm4378b1-fmac
>> + - brcm,bcm4387c2-fmac
>> - cypress,cyw4373-fmac
>> - cypress,cyw43012-fmac
>> - const: brcm,bcm4329-fmac
>> - const: brcm,bcm4329-fmac
>
> I suppose this helps with validation of device trees. However, nodes
> for PCI devices are not supposed to have a "compatible" property as
> the PCI vendor and device IDs are supposed to be used to identify a
> device.
>
> That does raise the question how a schema for additional properties
> for PCI device nodes is supposed to be defined...

Apparently using a "pciVVVV,DDDD" compatible is one way, see
bindings/net/wireless/qca,ath9k.yaml

There's apparently exactly one example of this in in-tree devicetrees:
boot/dts/rockchip/rk3399-gru-chromebook.dtsi

I guess this is the way to go then, unless Rob has a different idea :)

--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub

\
 
 \ /
  Last update: 2022-01-04 06:48    [W:0.124 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site